Prepare 1.21.0-RC1 release #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
reviewed
Jun 3, 2022
| junit-jupiter = { group = "org.junit.jupiter", name = "junit-jupiter", version = "5.8.2" } | ||
| slf4j-nop = { module = "org.slf4j:slf4j-nop", version = "1.7.36" } |
There was a problem hiding this comment.
Shall we really remove slf4j.nop? I thought this should prevent those log messages.
There was a problem hiding this comment.
As far as I know we now ship this dependency in detekt-core. It was necessary for detekt-formatting not to crash.
It does not crash anymore with 1.21.0-RC1.
There was a problem hiding this comment.
Yes, true. Now, I remember. This dependency is shipped with detekt itself.
=> Approved
schalkms
approved these changes
Jun 4, 2022
arturbosch
force-pushed
the
prepare-1.21.0
branch
from
07a76f2
to
83a77df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.