Add support for IJ 241, drop 221 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include updating Gradle to 8.5 and Gradle IJ plugin to 1.17.0
schalkms
approved these changes
Feb 6, 2024
|
Thanks for the tremendous help!! |
arturbosch
reviewed
Mar 31, 2024
| @@ -57,7 +57,7 @@ class RulesBrowserService : Disposable { | |||
| } | |||
|
|
|||
| private fun updateStyles() { | |||
| val ideTheme = if (StartupUiUtil.isUnderDarcula()) "dark" else "light" | |||
There was a problem hiding this comment.
hm, is it internal in future IJ versions than 222?
There was a problem hiding this comment.
Doesn't look like from the screenshot... But worst case scenario you can use JBColor.isBright()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this PR adds support for IJ 241, which is currently throwing an error due to an action missing the update thread override. Concurrently, we had to drop support for 221 as that API isn't available until 222. We also removed one deprecated-as-error API usage by copy-pasting that function into the plugin (yeah... I know), and replaced a deprecated IJ Platform function usage with its Kotlin stdlib equivalent.
Include updating Gradle to 8.5 and Gradle IJ plugin to 1.17.0; the verifier now runs on all latest supported versions of the IJ Platform. Smoke tested on 222 and 241 EAP 3.
I took the liberty of creating a changelog entry for 2.4.0