Remove running 'AutoCorrect' automatically on background and assign it to IDEA action #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2019 23:36
…ection manually Auto correction action can be called: Right click on the open kotlin source file -> 'Refactor' -> 'AutoCorrect by Detekt Rules'
dliakhov
commented
Dec 9, 2019
dliakhov
changed the title
|
Needs work. Found that plugin doesn't work on my other computer. |
|
Found that Auto Correct feature doesn't work for my configuration when checkbox 'Fail fast' or 'Build upon the default configuration' are unchecked for my custom configuration. |
dliakhov
changed the title
schalkms
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Many many thanks for picking this up! The implementation looks fine to me.
Cool! This fix also needs to be a part of the next plugin release.
I think it is correct behavior because my configuration, which I used for testing, didn't have rules for formatting.
I have the same opinion.
arturbosch
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I removed automatically running 'AutoCorrect' feature on background because it causes issues (see #53, #21)
I also removed option "Auto correct" it from the configuration window in settings
Added IDEA action "AutoCorrect by Detekt Rules" which is accessible in the Right-Click Menu -> "Refactor" -> "AutoCorrect by Detekt Rules" only for Kotlin files and when the plugin is enabled.
