EmptyFunctionBlock false positive: overridden function with comment in body

[technoir42]

detekt 1.0.0-RC15

This gets reported by EmptyFunctionBlock as violation:

override fun fetch() {
    // No-op
}

There is ignoreOverriddenFunctions but I don't want to ignore all overridden functions, just ones with a comment in their body.

[rock3r]

I have the same. An example that triggers it:

private interface AnimationEndListener : Animator.AnimatorListener {
    override fun onAnimationStart(animation: Animator) {
        // No-op
    }
    override fun onAnimationCancel(animation: Animator) {
        // No-op
    }
    override fun onAnimationRepeat(animation: Animator) {
        // No-op
    }
}

It looks like what the docs say: "This rule will not report functions overriding others.", is false, or more likely, the rule is bugged.

@technoir42 I think that config option is for the opposite case, that is, open functions that are meant to be overridden by subclasses.

[cortinico]

Yup I was able to reproduce it.
Apparently the logic use to check if the body had a comment or not was buggy. Moreover as @rock3r pointed out, the documentation was really confusing. Here the fix #1690