Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNAPSHOT process feedback #1826

Closed
TWiStErRob opened this issue Aug 18, 2019 · 1 comment · Fixed by #2079
Closed

SNAPSHOT process feedback #1826

TWiStErRob opened this issue Aug 18, 2019 · 1 comment · Fixed by #2079
Labels
Milestone

Comments

@TWiStErRob
Copy link
Member

TWiStErRob commented Aug 18, 2019

(I noticed these because I'm looking for a version to pull in to try #1818)


It looks like SNAPSHOT builds are not published any more. The last version is detekt-cli-1.0.0-20190804.140139-1.jar (acf2e3b) 14 days ago, it looks like SNAPSHOT publishing has been down on master builds between 996139d..bb40400


Additionally I think
https://github.com/arturbosch/detekt/blob/bb404007ac7fa859462775d599f537f7d7b1bd5e/gradle.properties#L1
should be updated with a commit right after tagging the released version in git, because otherwise you end up with these artifacts:

1.0-SNAPSHOT 20190804.123456-1
1.0-SNAPSHOT 20190810.123456-1
1.0
1.0-SNAPSHOT 20190812.123456-1
1.0-SNAPSHOT 20190823.123456-1
1.1
1.1-SNAPSHOT 20190827.123456-1

while it should be named like this by convention (note the version in front):

1.0-SNAPSHOT 20190804.123456-1
1.0-SNAPSHOT 20190810.123456-1
1.0
1.1-SNAPSHOT 20190812.123456-1
1.1-SNAPSHOT 20190823.123456-1
1.1
1.2-SNAPSHOT 20190827.123456-1

after release the SNAPSHOT is a preliminary published version of the next release not the just-released version.

@3flex 3flex added the build label Aug 19, 2019
@arturbosch
Copy link
Member

Hey, thanks for the reminder.
I just a 1.0.0 snapshot for you to try out the changes.

schalkms pushed a commit that referenced this issue Nov 8, 2019
I just added the execution permission to the file .buildscript/deploy_snapshot.sh with chmod +x .buildscript/deploy_snapshot.sh.

And I changed the SDK to one that we are using already.

You can see here that it was failing for that reason: https://travis-ci.org/arturbosch/detekt/jobs/607791661#L3885-L3886

Fixes #1826
@arturbosch arturbosch added this to the 1.2.0 milestone Nov 11, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this issue Dec 9, 2019
I just added the execution permission to the file .buildscript/deploy_snapshot.sh with chmod +x .buildscript/deploy_snapshot.sh.

And I changed the SDK to one that we are using already.

You can see here that it was failing for that reason: https://travis-ci.org/arturbosch/detekt/jobs/607791661#L3885-L3886

Fixes detekt#1826
smyachenkov pushed a commit to smyachenkov/detekt that referenced this issue Dec 9, 2019
I just added the execution permission to the file .buildscript/deploy_snapshot.sh with chmod +x .buildscript/deploy_snapshot.sh.

And I changed the SDK to one that we are using already.

You can see here that it was failing for that reason: https://travis-ci.org/arturbosch/detekt/jobs/607791661#L3885-L3886

Fixes detekt#1826
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants