Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Configuration off String type for default value. #3910

Closed
chao2zhang opened this issue Jun 27, 2021 · 1 comment · Fixed by #3928
Closed

Refactor Configuration off String type for default value. #3910

chao2zhang opened this issue Jun 27, 2021 · 1 comment · Fixed by #3928
Labels
core improvement never gets stale Mark Issues/PRs that should not be closed as they won't get stale

Comments

@chao2zhang
Copy link
Member

Currently, we are formatting the default value into a free-form String in Configuration. This is bypassing the typing system and couples the ConfigurationCollector with ConfigPrinter implicitly.

Originally posted by @chao2zhang in #3827 (comment)
@chao2zhang chao2zhang mentioned this issue Jun 27, 2021
Merged
@marschwar marschwar mentioned this issue Jul 1, 2021
Merged
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 2, 2021
@cortinico cortinico added never gets stale Mark Issues/PRs that should not be closed as they won't get stale and removed stale labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core improvement never gets stale Mark Issues/PRs that should not be closed as they won't get stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce DefaultValue type marschwar/detekt
3 participants
@chao2zhang @cortinico @schalkms