-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataClassContainsFunctions - allow conversion function #434
Comments
Is this related to the |
Hmm it might yeah. I'd say that conversion functions are defined with a prefix of |
Actually I also often use conversion functions for data classes but outside the class and in the same file. I would also argue that this should be the preferred way. |
@vanniktech @arturbosch Hello, should I add this feature to existing rules by default ( DataClassContainsFunctions, UseDataClass) or add additional configuration? |
@tagantroy I don't know. I still think such functions should be put at top level (extension functions). If you guys ( @vanniktech @schalkms ) give the issue a thumbs up, then why not @tagantroy :) |
I agree with @arturbosch |
@tagantroy here you have your go :) thanks for contributing! |
@arturbosch already merged, can we close it or mark as ready? |
Closed via #445 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics. |
What do you think about an option that allows conversion functions that take the Data class and basically map it to a different type. For instance:
The text was updated successfully, but these errors were encountered: