Separating positive and negative test cases for rules

[schalkms]

At the moment the tests check the violation count.
However, there can be a case where the sum is correct and the findings are wrong.
Separating positive and negative test cases could help to minimize this problem.

[arturbosch]

Which test cases do you have in mind? I'm not a fan of refactoring just because of refactoring. If the logic gets changed, we can change some test cases?

[schalkms]

Consider the following test file example for checking the naming convention.

class MyClass {}//valid
class myclass {} // report
class myClass {} // report

Detekt's current test case checks the violation count. However, detekt does not check if the wrong MyClass classes are reported. There could be case where the right one gets reported.

[arturbosch]

Ah now I understand. Yes, that makes sense and should be the preferred way.

[schalkms]

Closed with 0d869e3

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.