Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detekt CLI fails on Java 17+ in some cases when using detekt-formatting plugin with auto correct #5576

Closed
3flex opened this issue Nov 28, 2022 · 2 comments · Fixed by #5579
Closed

detekt CLI fails on Java 17+ in some cases when using detekt-formatting plugin with auto correct #5576

3flex opened this issue Nov 28, 2022 · 2 comments · Fixed by #5579
Labels
bug cli never gets stale Mark Issues/PRs that should not be closed as they won't get stale

Comments

@3flex
Copy link
Member

3flex commented Nov 28, 2022

Expected Behavior

I can run detekt CLI without applying any workarounds.

Observed Behavior

It can fail in some circumstances, see #5247 (comment)

Steps to Reproduce

TBC - opening tracking issue to link a brew issue to.

Context

Users using CLI and Java 17 without --add-opens java.base/java.lang=ALL-UNNAMED applied will see detekt failing in some circumstances.

Your Environment

  • Version of detekt used:
  • Version of Gradle used (if applicable):
  • Gradle scan link (add --scan option when running the gradle task):
  • Operating System and version:
  • Link to your project (if it's a public repository):
@3flex 3flex added the bug label Nov 28, 2022
@3flex 3flex mentioned this issue Nov 28, 2022
Closed
6 tasks
@3flex 3flex self-assigned this Nov 28, 2022
@3flex 3flex added the cli label Nov 28, 2022
@3flex 3flex changed the title detekt CLI fails on Java 17 in some cases when using detekt-formatting plugin with auto correct detekt CLI fails on Java 17+ in some cases when using detekt-formatting plugin with auto correct Nov 28, 2022
3flex added a commit to 3flex/detekt that referenced this issue Nov 28, 2022
@3flex
Allow access to nonpublic members of public types in java.base/java.l…
64520f6 
…ang package

Workaround detekt#5576
@3flex 3flex mentioned this issue Nov 28, 2022
Merged
@3flex 3flex removed their assignment Nov 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Feb 27, 2023
@3flex
Copy link
Member Author

3flex commented Feb 27, 2023

Still valid.

@github-actions github-actions bot removed the stale label Feb 28, 2023
@cortinico cortinico added the never gets stale Mark Issues/PRs that should not be closed as they won't get stale label Mar 1, 2023
3flex added a commit to 3flex/detekt that referenced this issue Mar 13, 2023
@3flex
Allow access to nonpublic members of public types in java.base/java.l…
fb23f66 
…ang package

Workaround detekt#5576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli never gets stale Mark Issues/PRs that should not be closed as they won't get stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow access to nonpublic members of public types in java.base/java.lang package 3flex/detekt
2 participants
@3flex @cortinico