Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyDefaultConstructor incorrect behavior #723

Closed
Mygod opened this issue Feb 4, 2018 · 2 comments
Closed

EmptyDefaultConstructor incorrect behavior #723

Mygod opened this issue Feb 4, 2018 · 2 comments
Labels
bug rules
Milestone
RC6-4

Comments

@Mygod
Copy link
Contributor

Mygod commented Feb 4, 2018

https://github.com/shadowsocks/shadowsocks-android/blob/9a43c78e7b60b00a587d6c2c24e748ec94f50961/mobile/src/main/java/com/github/shadowsocks/database/KeyValuePair.kt#L28

In this example, the parentheses can't be omitted because it defines another constructor that takes no argument.
arturbosch pushed a commit that referenced this issue Feb 6, 2018
@schalkms @arturbosch
Fixed incorrect behavior of EmptyDefaultConstructor - #723
cc010aa 
A parameterless constructor which is called by another constructor
should not be reported.
@arturbosch
Copy link
Member

arturbosch commented Feb 6, 2018 •
edited
Loading

I did not know this was even possible thanks :D
Edit: Fixed by #724

arturbosch pushed a commit that referenced this issue Feb 7, 2018
@schalkms @arturbosch
Fixed incorrect behavior of EmptyDefaultConstructor - #723
3b5c26a 
A parameterless constructor which is called by another constructor
should not be reported.
@arturbosch arturbosch added this to the RC6-4 milestone Mar 15, 2018
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug rules
Projects
None yet
Milestone
RC6-4
Development

No branches or pull requests
3 participants
@Mygod @arturbosch @schalkms