Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "detektCheck" Gradle task is never UP-TO-DATE #725

Closed
sschuberth opened this issue Feb 5, 2018 · 7 comments · Fixed by #743
Closed

The "detektCheck" Gradle task is never UP-TO-DATE #725

sschuberth opened this issue Feb 5, 2018 · 7 comments · Fixed by #743
Milestone

Comments

@sschuberth
Copy link
Contributor

I just realized that running the exact same ./gradlew detektCheck task two times in a row without changing any source code does not show the detektCheck task to be UP-TO-DATE, as expected, but runs the task again. Is that by design? If so, I'd vote for changing that for performance reasons, and because tasks can be easily forced to rerun with the --rerun-tasks Gradle command line option.

@vanniktech
Copy link
Contributor

The main drawback is that right now it's not incremental which it should be.

@arturbosch
Copy link
Member

So how to change that? Any gradle experts here :)

@vanniktech
Copy link
Contributor

We need to declare an input. Probably the source files. Gradle will then do the rest of the work.

@mkobit
Copy link
Contributor

mkobit commented Feb 6, 2018

The tasks should have both inputs and outputs.

@vanniktech
Copy link
Contributor

Right as output we could use our output.

@mkobit
Copy link
Contributor

mkobit commented Feb 7, 2018

I can take a pass at the Gradle stuff sometime next week after #719 is completed

@arturbosch arturbosch added this to the RC6-4 milestone Mar 15, 2018
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Mar 19, 2018
This version as the UP-TO-DATE check fixed, see

detekt/detekt#725

Also, the "warningThreshold" and 'failThreshold' properties were
deprecated in favor of the new "maxIssues" property, see

detekt/detekt#313
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Mar 20, 2018
This version as the UP-TO-DATE check fixed, see

detekt/detekt#725

Also, the "warningThreshold" and "failThreshold" properties were
deprecated in favor of the new "maxIssues" property, see

detekt/detekt#313
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants