Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix wildcard to SplitPattern #1002

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Add prefix wildcard to SplitPattern #1002

merged 2 commits into from
Jul 17, 2018

Conversation

egor-n
Copy link
Contributor

@egor-n egor-n commented Jul 17, 2018

Fixes #1001.

@egor-n
Copy link
Contributor Author

egor-n commented Jul 17, 2018

I'm not sure why 9bc0b40 hasn't failed the build 🤷‍♂️

@egor-n
Copy link
Contributor Author

egor-n commented Jul 17, 2018

Yeah, I can't get it to fail on my machine either when running ./gradlew :detekt-api:test from the command line.

Running the tests from the IDE seems to do the trick, though.

@arturbosch arturbosch merged commit cd19738 into detekt:master Jul 17, 2018
@egor-n
Copy link
Contributor Author

egor-n commented Jul 17, 2018

@arturbosch is the CI issue known/tracked somewhere?

@arturbosch
Copy link
Member

I could reproduce the same behaviour. Test fails in IDE but not on cli.
Well its tracked here. Idk what we can do else. Could be a spek or junit thingy.
If this makes any problems later we will link here.

@egor-n egor-n deleted the split-pattern-prefix-wildcard branch July 27, 2018 11:44
@arturbosch arturbosch added this to the RC8 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
RC8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@egor-n @arturbosch @schalkms