Prepare rc8 #1011
Merged
Prepare rc8 #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
approved these changes
Jul 22, 2018
CONTRIBUTING.md
Outdated
| - `gradle detektCheck` should not report any errors | ||
| - This repo uses tabs! Make sure your code is properly formatted. | ||
| - Use idea-code-style.xml for coding style . | ||
| - We use [Spek](https://github.com/spekframework/spek) for testing. | ||
| - Feel free to add your name to the contributors list at the end of the readme file when opening a pull request. | ||
| - The code in `detekt-api`and any rule in `detekt-rules` must be documented. We generate documentation for our website based on this modules. |
There was a problem hiding this comment.
missing space between detekt-api and and
| @@ -2,11 +2,13 @@ | |||
|
|
|||
| - Read [this article](https://chris.beams.io/posts/git-commit/) before writing commit messages | |||
| - Copy the file `commit-msg` to `.git/hooks` | |||
| - Use `gradle build -x dokka` to build the source but exclude documentation jar generating to save time. | |||
| @@ -61,3 +71,91 @@ pluginBundle { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| bintray { | |||
| user = System.getenv("BINTRAY_USER") ?: "" | |||
There was a problem hiding this comment.
I'm glad that you have automated the bintray publishing.
gradle.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| detektVersion=1.0.0.RC7-3 | |||
| detektVersion=1.0.0.RC8 | |||
| usedDetektVersion=1.0.0.RC7-3 | |||
There was a problem hiding this comment.
jap, after bintray stuff is uploaded to not get the CI errors :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.