Use correct accessor method for config in LazyRegex #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding the issue! Was not aware of that internal when implementing LazyRegex! |
schalkms
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1122 and similar issues reported on Slack.
LazyRegexwas directly accessing the config. However instead it should only access the methods defined byConfigAware.ConfigAware, which is a base class ofRuleensures that the config works on the correctsubConfig. Usingconfigdirectly however operates on the entire config of the wholeRuleSet.As this is a really easy mistake to make, which is quite hard to debug, we should make it harder to directly access the
configin aRuleclass to prevent similar issues in the future.