Rename Plain reporting to Txt. #1184
Conversation
|
I think this needs one of the many open PRs who fix the master build. |
| assertThat(plainReport.kind).isEqualTo(PlainOutputReport::class.java.simpleName) | ||
| assertThat(plainReport.path).isEqualTo(Paths.get("/tmp/path2")) | ||
| it("it should properly parse TXT report entry") { | ||
| val textRepot = reports[1] |
| @@ -25,7 +25,7 @@ internal class ReportsSpec : Spek({ | |||
| val args = arrayOf( | |||
| "--input", "/tmp/must/be/given", | |||
| "--report", "xml:/tmp/path1", | |||
| "--report", "plain:/tmp/path2", | |||
| "--report", "text:/tmp/path2", | |||
There was a problem hiding this comment.
Should this not be txt? I'd hope the test also fails with this current version? (After a rebase, master should be green again).
There was a problem hiding this comment.
Whops. Yes will fix tomorrow. Had this first but my master was super old and I screwed up when resolving the changes.
|
Looks good! Please add this change to the (not yet created) migrate section of RC10, so I won't forget this. |
Can you elaborate?
You can do that if you select Squash and merge |
|
@vanniktech The migration guide for the next release is currently in the commented out part at the top of: https://raw.githubusercontent.com/arturbosch/detekt/master/docs/pages/changelog.md. |
|
Should be good to go now. I believe. |
|
Rebased and merged this manually, thanks! |
Fixes #1111