Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare RC13 #1462

Merged
merged 6 commits into from
Feb 10, 2019
Merged

Prepare RC13 #1462

merged 6 commits into from
Feb 10, 2019

Conversation

arturbosch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 9, 2019 •
edited
Loading

Codecov Report

Merging #1462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1462   +/-   ##
=========================================
  Coverage     74.68%   74.68%           
  Complexity     1720     1720           
=========================================
  Files           327      327           
  Lines          5238     5238           
  Branches        950      950           
=========================================
  Hits           3912     3912           
  Misses          805      805           
  Partials        521      521

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445ffb0...4520344. Read the comment docs.

vanniktech
vanniktech reviewed Feb 9, 2019
View reviewed changes
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really ready for this? Frankly speaking, I don't think so.

@arturbosch
Copy link
Member Author

Sure, we have more than I ever wanted to implement for a 1.0. Idk what should be missing? I want to start making minor releases ^^.

@vanniktech
Copy link
Contributor

There have been so many API changes in the last few releases. (Including from RC12 to 1.0.0)
I would not be confident calling this a 1.0.0 but also again I'm not a real maintainer.

What's the benefit for having a 1.0.0 instead of a RC13? Personally, I don't see one.

@arturbosch
Copy link
Member Author

Actually your right, things like LargeClass and LongMethod rework need a RC13 because they are active by default. Will change to RC13.

@arturbosch arturbosch changed the title Prepare 1.0.0 Prepare RC13 Feb 9, 2019
vanniktech
vanniktech approved these changes Feb 9, 2019
View reviewed changes
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@arturbosch arturbosch merged commit 6927935 into master Feb 10, 2019
@arturbosch arturbosch deleted the prepare-1.0.0 branch February 10, 2019 12:41
@arturbosch arturbosch added this to the RC13 milestone Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
RC13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturbosch @codecov-io @vanniktech