Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Skip default install step #1557

Merged
merged 1 commit into from Mar 26, 2019

Conversation

3flex
Copy link
Member

@3flex 3flex commented Mar 26, 2019

Travis runs ./gradlew assemble by default, which means any custom flags set (such as --build-cache and -PwarningsAsErrors=true) don't apply. Skipping the default install steps means the build will only start at the ./gradlew build step in the script block.

Each AppVeyor build is now down to about 5-6 mins thanks to the build cache - this should bring the Travis build down to a similar level since the --build-cache flag will now apply to the assemble task.

Travis runs ./gradlew assemble by default, which means any custom flags
set (such as --build-cache and -PwarningsAsErrors=true) don't apply.
Skipping the default install steps means the build will only start at
the ./gradlew build step in the `script` block.
@3flex 3flex changed the title Skip default install step Travis: Skip default install step Mar 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1557   +/-   ##
=========================================
  Coverage     75.69%   75.69%           
  Complexity     1727     1727           
=========================================
  Files           316      316           
  Lines          5156     5156           
  Branches        949      949           
=========================================
  Hits           3903     3903           
  Misses          737      737           
  Partials        516      516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859a771...443ac6e. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@arturbosch arturbosch merged commit 7d8fee9 into detekt:master Mar 26, 2019
@arturbosch arturbosch added this to the RC15 milestone Mar 26, 2019
@3flex 3flex deleted the travis_skip_install branch March 26, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants