Add rules to suggest usage of check(), require() and error().

detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseCheckOrError.kt

@@ -44,12 +44,15 @@ class UseCheckOrError(config: Config = Config.empty) : Rule(config) {
     )
 
     override fun visitThrowExpression(expression: KtThrowExpression) {
-        if (expression.isIllegalStateException()) {
+        if (expression.isIllegalStateExceptionWithoutCause()) {
             report(CodeSmell(issue, Entity.from(expression), issue.description))
         }
     }
 
-    private fun KtThrowExpression.isIllegalStateException(): Boolean {
-        return findDescendantOfType<KtCallExpression>()?.firstChild?.text == "IllegalStateException"
+    private fun KtThrowExpression.isIllegalStateExceptionWithoutCause(): Boolean {
+        val callExpression = findDescendantOfType<KtCallExpression>()
+        val argumentCount = callExpression?.valueArgumentList?.children?.size ?: 0
+
+        return callExpression?.firstChild?.text == "IllegalStateException" && argumentCount < 2
     }
 }

detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseRequire.kt

@@ -42,6 +42,9 @@ class UseRequire(config: Config = Config.empty) : Rule(config) {
     }
 
     private fun KtThrowExpression.isIllegalArgumentException(): Boolean {
-        return findDescendantOfType<KtCallExpression>()?.firstChild?.text == "IllegalArgumentException"
+        val callExpression = findDescendantOfType<KtCallExpression>()
+        val argumentCount = callExpression?.valueArgumentList?.children?.size ?: 0
+
+        return callExpression?.firstChild?.text == "IllegalArgumentException" && argumentCount < 2
     }
 }

detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseCheckOrErrorSpec.kt

@@ -66,5 +66,15 @@ class UseCheckOrErrorSpec : Spek({
                 }"""
             assertThat(subject.lint(code)).isEmpty()
         }
+
+        it("does not report an issue if the exception thrown has a message and a cause") {
+            val code = """
+                private fun missing(): Nothing {
+                    if  (cause != null) {
+                        throw IllegalStateException("message", cause)
+                    }
+                }"""
+            assertThat(subject.lint(code)).isEmpty()
+        }
     }
 })

detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseRequireSpec.kt

@@ -56,5 +56,13 @@ class UseRequireSpec : Spek({
                 }"""
             assertThat(subject.lint(code)).isEmpty()
         }
+
+        it("does not report an issue if the exception thrown has a message and a cause") {
+            val code = """
+                private fun x(a: Int): Nothing {
+                    throw IllegalArgumentException("message", cause)
+                }"""
+            assertThat(subject.lint(code)).isEmpty()
+        }
     }
 })