Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorizes CLI output. #1581

Merged
merged 1 commit into from Apr 15, 2019
Merged

Colorizes CLI output. #1581

merged 1 commit into from Apr 15, 2019

Conversation

marschwar
Copy link
Contributor

@marschwar marschwar commented Apr 9, 2019

Displays code smells in yellow and failures in red.
Closes #310

The issue did not really contain any details so I just free styled. Comments welcome. Looking forward to seeing what it looks like on windows.

Displays code smells in yellow and failures in red.
Closes #310
@codecov-io
Copy link

Codecov Report

Merging #1581 into master will increase coverage by 0.06%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1581      +/-   ##
============================================
+ Coverage     79.37%   79.44%   +0.06%     
  Complexity     1933     1933              
============================================
  Files           330      331       +1     
  Lines          5416     5434      +18     
  Branches        987      987              
============================================
+ Hits           4299     4317      +18     
  Misses          593      593              
  Partials        524      524
Impacted Files Coverage Δ Complexity Δ
.../gitlab/arturbosch/detekt/cli/console/Colorizer.kt 100% <100%> (ø) 0 <0> (?)
...ab/arturbosch/detekt/cli/console/FindingsReport.kt 100% <100%> (ø) 5 <0> (ø) ⬇️
...rturbosch/detekt/cli/console/BuildFailureReport.kt 97.67% <95%> (+0.53%) 17 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4399f7...a1e6a67. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Does this also colorize the specific code smell?
e.g.

Ruleset: complexity
  TooManyFunctions - 12/10 - [Findings.kt] - Line/Column=(1,1) - Path=...

@marschwar
Copy link
Contributor Author

See https://ci.appveyor.com/project/arturbosch/detekt/builds/23723628/job/sy6jre752wtniqcb#L562

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example. Looks fine!

@arturbosch arturbosch added this to the RC15 milestone Apr 15, 2019
@arturbosch arturbosch merged commit ea3175f into detekt:master Apr 15, 2019
@marschwar marschwar deleted the colorize branch April 16, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorize output in cli
4 participants