Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: Upgrade the ktlint version to 0.33.0 #1692

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

sschuberth
Copy link
Contributor

See https://github.com/pinterest/ktlint/releases/tag/0.33.0. Note that
ktlint decided to remove the NoWildcardImportsRule from the
StandardRuleSetProvider, but the code is still present. For now, do not
change detekt's behavior in this regard to maintain the current user
experience.

See https://github.com/pinterest/ktlint/releases/tag/0.33.0. Note that
ktlint decided to remove the NoWildcardImportsRule from the
StandardRuleSetProvider, but the code is still present. For now, do not
change detekt's behavior in this regard to maintain the current user
experience.
@codecov-io
Copy link

Codecov Report

Merging #1692 into master will decrease coverage by 7.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1692      +/-   ##
============================================
- Coverage     79.81%   72.19%   -7.62%     
+ Complexity     1594      212    -1382     
============================================
  Files           229       59     -170     
  Lines          4335      723    -3612     
  Branches        829      109     -720     
============================================
- Hits           3460      522    -2938     
+ Misses          428      142     -286     
+ Partials        447       59     -388
Impacted Files Coverage Δ Complexity Δ
...detekt/rules/style/UnderscoresInNumericLiterals.kt
...osch/detekt/rules/style/OptionalAbstractKeyword.kt
...main/kotlin/io/gitlab/arturbosch/detekt/cli/LOG.kt
...osch/detekt/rules/bugs/UselessPostfixExpression.kt
...osch/detekt/rules/style/NestedClassesVisibility.kt
...etekt/rules/bugs/IteratorHasNextCallsNextMethod.kt
...h/detekt/rules/documentation/PrivateElementUtil.kt
.../gitlab/arturbosch/detekt/rules/ThrowExtensions.kt
...gitlab/arturbosch/detekt/cli/runners/AstPrinter.kt
...bosch/detekt/rules/style/UnnecessaryParentheses.kt
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11abb88...81ab8da. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #1692 into master will decrease coverage by 7.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1692      +/-   ##
============================================
- Coverage     79.81%   72.19%   -7.62%     
+ Complexity     1594      212    -1382     
============================================
  Files           229       59     -170     
  Lines          4335      723    -3612     
  Branches        829      109     -720     
============================================
- Hits           3460      522    -2938     
+ Misses          428      142     -286     
+ Partials        447       59     -388
Impacted Files Coverage Δ Complexity Δ
...detekt/rules/style/UnderscoresInNumericLiterals.kt
...osch/detekt/rules/style/OptionalAbstractKeyword.kt
...main/kotlin/io/gitlab/arturbosch/detekt/cli/LOG.kt
...osch/detekt/rules/bugs/UselessPostfixExpression.kt
...osch/detekt/rules/style/NestedClassesVisibility.kt
...etekt/rules/bugs/IteratorHasNextCallsNextMethod.kt
...h/detekt/rules/documentation/PrivateElementUtil.kt
.../gitlab/arturbosch/detekt/rules/ThrowExtensions.kt
...gitlab/arturbosch/detekt/cli/runners/AstPrinter.kt
...bosch/detekt/rules/style/UnnecessaryParentheses.kt
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11abb88...81ab8da. Read the comment docs.

@arturbosch arturbosch merged commit 52b8d1e into detekt:master Jun 15, 2019
@arturbosch arturbosch added this to the 1.0.0 milestone Jun 15, 2019
@sschuberth sschuberth deleted the ktlint-bump branch June 16, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants