Support guard clause exclusion for ThrowsCount rule #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
===========================================
+ Coverage 80.68% 80.7% +0.02%
- Complexity 1985 1991 +6
===========================================
Files 329 329
Lines 5591 5597 +6
Branches 1021 1022 +1
===========================================
+ Hits 4511 4517 +6
Misses 539 539
Partials 541 541
Continue to review full report at Codecov.
|
arturbosch
reviewed
Oct 24, 2019
| val count = function | ||
| .collectDescendantsOfType<KtThrowExpression>() | ||
| .filterNot { | ||
| excludeGuardClauses && it.isGuardClause() |
There was a problem hiding this comment.
nit: can we put this line on the same as filterNot ?
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Support guard clause exclusion for ThrowsCount rule * Fix feedback issues
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Support guard clause exclusion for ThrowsCount rule * Fix feedback issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2006.