Revert change to calculate signature for formatting rules due to performance reasons #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
reviewed
Nov 23, 2019
detekt-formatting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRule.kt
Outdated
Show resolved
Hide resolved
arturbosch
force-pushed
the
revert-formatting-changes
branch
from
f3d2c26
to
276c0f3
Compare
|
Build is failing for OSX due to Java 13. Why does osx 12.3 use Java 13 which is unsupported by Gradle 5.6.X ... |
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…ormance reasons (detekt#2120) Reverts detekt#2083 and detekt#2107
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…ormance reasons (detekt#2120) Reverts detekt#2083 and detekt#2107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2083 and #2107
Tested on detekt's codebase with cli and command
jrun detekt-cli/build/libs/detekt-cli-1.2.0-all.jar -in "**/src/main/kotlin/**/*.kt" -i .detekt run without plugins ~5s
detekt run with formatting plugin and no signature reported ~8s
detekt run with formatting plugin and signature ~12s
Formatting is slower and with the recent change it got even slower.