-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Gradle 5 tests only for JDK versions < 13 #2143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
============================================
+ Coverage 80.5% 80.52% +0.02%
Complexity 2017 2017
============================================
Files 336 336
Lines 5801 5808 +7
Branches 1063 1063
============================================
+ Hits 4670 4677 +7
Misses 564 564
Partials 567 567
Continue to review full report at Codecov.
|
versions.add("5.0") | ||
} | ||
versions.add("6.0.1") | ||
return versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return if (jdkVersion < 13) {
listOf("5.0", "6.0.1")
} else {
listOf("6.0.1")
}
I think that it's easier to know which versions are going to be tested like this. You could even create two consts: GRADLE_5
and GRADLE_6
. But I think that the strings helps more to the readability than the constants to the maintanability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree here in terms of readability:
private fun getGradleVersionsUnderTest() =
if (jdkVersion() < 13) {
listOf("5.0", "6.0.1")
} else {
listOf("6.0.1")
}
* Run Gradle 5 tests only for JDK versions < 13 * Refactor GetGradleVersion logic for test
* Run Gradle 5 tests only for JDK versions < 13 * Refactor GetGradleVersion logic for test
No description provided.