Rule: ModifierOrder #239
Merged
Rule: ModifierOrder #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
reviewed
Jul 25, 2017
| given("a kt parameter with wrongly ordered modifiers") { | ||
| val code = "lateinit internal private val test: String" | ||
|
|
||
| it("should report the package statement and import statements by default") { |
There was a problem hiding this comment.
Oh.. Good catch. Copy pasted the MaxLineLengthSpec and forgot to change the description 🙃
| given("a kt parameter with correctly ordered modifiers") { | ||
| val code = "private internal lateinit val test: String" | ||
|
|
||
| it("should report the package statement and import statements by default") { |
Mauin
force-pushed
the
mr/modifier_order_rule
branch
from
14c9898
to
8feda1c
Compare
|
Updated the tests and included a Test class for the Modifier order. It felt wrong writing that class with the modifiers all over the place... 😐 |
arturbosch
reviewed
Jul 26, 2017
| it("should not report modifiers") { | ||
| val rule = ModifierOrder() | ||
|
|
||
| val findings = rule.lint(file.text) |
There was a problem hiding this comment.
Just give Case.Default.path to lint or you compile two times the file :)
arturbosch
reviewed
Jul 26, 2017
| } | ||
|
|
||
| given("a kt file with correctly ordered modifiers") { | ||
| val file = compileForTest(Case.ModifierOrder.path()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129
The modifier order and rule setup was inspired by ktlint: https://github.com/shyiko/ktlint/blob/master/ktlint-ruleset-standard/src/main/kotlin/com/github/shyiko/ktlint/ruleset/standard/ModifierOrderRule.kt#L35