Add test for BaselineHandler #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
reviewed
Mar 19, 2020
| @@ -6,5 +6,6 @@ | |||
| </Blacklist> | |||
| <Whitelist> | |||
| <ID>FeatureEnvy:Signature</ID> | |||
| <ID></ID> | |||
There was a problem hiding this comment.
It does, but should it? Allowing this seems like a way to allow noise in our baselines.
There was a problem hiding this comment.
Agree, it does not add any value, can we throw an error("") for this?
The BaselineHandler xml parser should handle empty ID entries.
* Move invalid XML ID tag to own file * Make BaselineHandler visibility internal
Codecov Report
@@ Coverage Diff @@
## master #2462 +/- ##
============================================
+ Coverage 83.24% 83.29% +0.04%
- Complexity 2183 2186 +3
============================================
Files 359 359
Lines 6208 6208
Branches 1139 1139
============================================
+ Hits 5168 5171 +3
+ Misses 465 464 -1
+ Partials 575 573 -2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaselineHandler xml parser should handle empty ID entries.