Skip to content

Preserve original exception when loading an invalid config#2884

Merged
schalkms merged 1 commit into
masterfrom
more-debuggable-config
Jul 20, 2020
Merged

Preserve original exception when loading an invalid config#2884
schalkms merged 1 commit into
masterfrom
more-debuggable-config

Conversation

@arturbosch

@arturbosch arturbosch commented Jul 20, 2020

Copy link
Copy Markdown
Member

@arturbosch arturbosch changed the title Preserve original exception when loading an invalid config - #2841 Preserve original exception when loading an invalid config Jul 20, 2020
@arturbosch arturbosch added this to the 1.10.1 milestone Jul 20, 2020
@codecov

codecov Bot commented Jul 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2884 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2884      +/-   ##
============================================
+ Coverage     80.17%   80.21%   +0.04%     
  Complexity     2417     2417              
============================================
  Files           421      421              
  Lines          7358     7360       +2     
  Branches       1343     1343              
============================================
+ Hits           5899     5904       +5     
+ Misses          764      762       -2     
+ Partials        695      694       -1     
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 100.00% <100.00%> (+13.33%) 0.00 <0.00> (ø)
...itlab/arturbosch/detekt/api/internal/YamlConfig.kt 84.61% <100.00%> (+3.84%) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de31f1...aa74dee. Read the comment docs.

@schalkms schalkms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test case for it?

@arturbosch arturbosch force-pushed the more-debuggable-config branch from ee06206 to aa74dee Compare July 20, 2020 17:09
@arturbosch

Copy link
Copy Markdown
Member Author

Should we add a test case for it?

Yes! Thanks, also forgot to add the document files

@schalkms schalkms merged commit ed1106b into master Jul 20, 2020
@schalkms schalkms deleted the more-debuggable-config branch July 20, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants