New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informative message to UselessCallOnNotNull report #2920
Add informative message to UselessCallOnNotNull report #2920
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
============================================
- Coverage 80.23% 80.23% -0.01%
- Complexity 2448 2449 +1
============================================
Files 421 421
Lines 7402 7407 +5
Branches 1352 1354 +2
============================================
+ Hits 5939 5943 +4
Misses 764 764
- Partials 699 700 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding some tests would be beneficial.
Yup, @veyndan you should be able to assert on the |
@schalkms @cortinico I expanded the previous tests to include verification of the error message. I'm not too sure why the code coverage tool is failing though… |
The failure is related to a drop in codecov coverage for your diff. You can disregard this has it has been really flaky recently (also the overall coverage is increasing). |
No description provided.