Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informative message to UselessCallOnNotNull report #2920

Merged
merged 2 commits into from Aug 4, 2020
Merged

Add informative message to UselessCallOnNotNull report #2920

merged 2 commits into from Aug 4, 2020

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Aug 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #2920 into master will decrease coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2920      +/-   ##
============================================
- Coverage     80.23%   80.23%   -0.01%     
- Complexity     2448     2449       +1     
============================================
  Files           421      421              
  Lines          7402     7407       +5     
  Branches       1352     1354       +2     
============================================
+ Hits           5939     5943       +4     
  Misses          764      764              
- Partials        699      700       +1     
Impacted Files Coverage Δ Complexity Δ
...urbosch/detekt/rules/style/UselessCallOnNotNull.kt 80.76% <70.00%> (-0.19%) 8.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ac74a...9262d9e. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding some tests would be beneficial.

@cortinico
Copy link
Member

I think adding some tests would be beneficial.

Yup, @veyndan you should be able to assert on the findings.message inside your tests

@cortinico cortinico added the rules label Aug 3, 2020
@veyndan veyndan requested a review from schalkms August 4, 2020 11:00
@veyndan
Copy link
Contributor Author

veyndan commented Aug 4, 2020

@schalkms @cortinico I expanded the previous tests to include verification of the error message. I'm not too sure why the code coverage tool is failing though…

@cortinico
Copy link
Member

@schalkms @cortinico I expanded the previous tests to include verification of the error message. I'm not too sure why the code coverage tool is failing though…

The failure is related to a drop in codecov coverage for your diff. You can disregard this has it has been really flaky recently (also the overall coverage is increasing).

@schalkms schalkms merged commit 4d0d8c9 into detekt:master Aug 4, 2020
@veyndan veyndan deleted the housekeeping/UselessCallOnNotNull-reporting-message branch August 5, 2020 08:05
@arturbosch arturbosch added this to the 1.11.0 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants