UnnecessaryLet: fix false positive when let is used for destructuring #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2968 +/- ##
============================================
+ Coverage 80.25% 80.29% +0.03%
- Complexity 2465 2478 +13
============================================
Files 423 424 +1
Lines 7440 7479 +39
Branches 1358 1370 +12
============================================
+ Hits 5971 6005 +34
+ Misses 763 760 -3
- Partials 706 714 +8
Continue to review full report at Codecov.
|
schalkms
approved these changes
Aug 14, 2020
| return bodyExpression?.countVarRefs(firstParameter?.text ?: IT_LITERAL) | ||
| private fun KtLambdaExpression.countReferences(): Int { | ||
| val bodyExpression = bodyExpression ?: return 0 | ||
| val firstParameter = firstParameter |
There was a problem hiding this comment.
I think this one can be removed safely.
There was a problem hiding this comment.
val firstParameter = firstParameter
|
👏 |
cortinico
approved these changes
Aug 14, 2020
| val bodyExpression = bodyExpression ?: return 0 | ||
| val firstParameter = firstParameter | ||
| val destructuringDeclaration = firstParameter?.destructuringDeclaration | ||
| return destructuringDeclaration?.entries?.sumBy { bodyExpression.countVarRefs(it.nameAsSafeName.asString()) } |
There was a problem hiding this comment.
Can you divide this expression in 2? Having multiple occurrencies of the elvis operator on the same line makes the code harder to read.
...kt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLetSpec.kt
Outdated
Show resolved
Hide resolved
schalkms
approved these changes
Aug 15, 2020
cortinico
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2966