Equals() smells #297
Equals() smells #297
Conversation
|
|
||
| class EqualsNullCall(config: Config = Config.empty) : Rule(config) { | ||
|
|
||
| override val issue = Issue("EqualsWithHashCodeExist", Severity.Defect, |
There was a problem hiding this comment.
Forgot to rename the issue id
There was a problem hiding this comment.
Why is this a defect? This looks like a style check for kotlin newcomers ?
|
|
||
| class WrongEqualsTypeParameter(config: Config = Config.empty) : Rule(config) { | ||
|
|
||
| override val issue = Issue("WrongEqualsTypeParameter", Severity.Defect, |
| @@ -38,8 +38,14 @@ potential-bugs: | |||
| active: true | |||
| DuplicateCaseInWhenExpression: | |||
| active: true | |||
| EqualsAlwaysReturnsTrueOrFalse: | |||
| active: true | |||
There was a problem hiding this comment.
Please turn all the rules to active: false. Will turn them on after some versions.
There was a problem hiding this comment.
We need to be careful with this though I'd expect them to only get turned on by default with a major bump like 1.x to 2.x
Another solution would be to keep having detekt in RC for a few more weeks to gather some more feedback
There was a problem hiding this comment.
I think the WrongEqualsTypeParameter is rule is like a must have for 1.0. AlwaysTrueOrFalse is good too. Why would you expect a major version bump?
Yeah I want to have a good 1.0 release and I think I won't turn on any new rules active until then.
I will also need some weeks for the wiki to be finished ... so little time :)
There was a problem hiding this comment.
Mostly because the other code quality tools do it like this. But obviously we could do this differently however we should point this out in the README then.
|
Manually merged via 54f3787 |
No description provided.