Fix false positive for UnnecessaryLet with disabled type resolution#2991
Merged
BraisGabin merged 2 commits intodetekt:masterfrom Aug 20, 2020
Merged
Conversation
BraisGabin
reviewed
Aug 20, 2020
Member
BraisGabin
left a comment
There was a problem hiding this comment.
Could you add this example to the tests?
val a = listOf<List<String>?>(listOf(""))
.map { list -> list?.let { it + it } }To ensure that in the future we just remove the if thinking "it's not necessary"
Codecov Report
@@ Coverage Diff @@
## master #2991 +/- ##
=========================================
Coverage 80.29% 80.29%
+ Complexity 2478 2477 -1
=========================================
Files 424 424
Lines 7479 7479
Branches 1370 1370
=========================================
Hits 6005 6005
Misses 760 760
Partials 714 714
Continue to review full report at Codecov.
|
schalkms
approved these changes
Aug 20, 2020
arturbosch
approved these changes
Aug 20, 2020
BraisGabin
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is the same we applied for #2938 (restricting the rule to type resolution only).
Fixes #2987