Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate working for Type Resolution #3011

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

cortinico
Copy link
Member

I'm consolidating the naming around our Type Resolution feature. We sometimes refer to it as Type and Symbols solving. I've updated all the occurrences to use Type Resolution (TR, it's shorter and easier to understand).

Context here #2993 (comment) suggested by @realdadfish

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you need to update :detekt-generator for the generated documentation.

Copy link
Contributor

@realdadfish realdadfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #3011 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3011      +/-   ##
============================================
- Coverage     79.78%   79.73%   -0.06%     
  Complexity     2506     2506              
============================================
  Files           427      427              
  Lines          7534     7539       +5     
  Branches       1420     1421       +1     
============================================
  Hits           6011     6011              
- Misses          767      772       +5     
  Partials        756      756              
Impacted Files Coverage Δ Complexity Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <ø> (ø) 3.00 <0.00> (ø)
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 66.17% <ø> (ø) 4.00 <0.00> (ø)
...enerator/printer/rulesetpage/RuleSetPagePrinter.kt 87.80% <100.00%> (ø) 18.00 <0.00> (ø)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 53.84% <0.00%> (-1.84%) 10.00% <0.00%> (ø%)
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 27.90% <0.00%> (-0.67%) 16.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52518f...3a0e9fb. Read the comment docs.

@arturbosch arturbosch merged commit 2c6d0ad into detekt:master Aug 24, 2020
@arturbosch arturbosch added this to the 1.12.0 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants