Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat comment as non-empty block body #303

Merged
merged 2 commits into from Aug 14, 2017
Merged

Treat comment as non-empty block body #303

merged 2 commits into from Aug 14, 2017

Conversation

koral--
Copy link
Contributor

@koral-- koral-- commented Aug 13, 2017

@arturbosch
Copy link
Member

Seems reasonable to me.

Please update the test case and use the rule directly instead of copying the hasCommentInside code :)

@koral--
Copy link
Contributor Author

koral-- commented Aug 14, 2017

Done.

@arturbosch arturbosch merged commit e81a516 into detekt:master Aug 14, 2017
@arturbosch
Copy link
Member

Thanks!

@koral-- koral-- deleted the comment-block branch August 14, 2017 12:35
@arturbosch arturbosch modified the milestone: next Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants