Improve documentation for Gradle repositories setup #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3030 +/- ##
=========================================
Coverage 79.31% 79.31%
Complexity 2562 2562
=========================================
Files 432 432
Lines 7725 7725
Branches 1466 1466
=========================================
Hits 6127 6127
Misses 814 814
Partials 784 784 Continue to review full report at Codecov.
|
|
We need to do something with |
schalkms
approved these changes
Aug 28, 2020
arturbosch
reviewed
Aug 28, 2020
| content { | ||
| // just allow to include kotlinx projects | ||
| // detekt needs 'kotlinx-html' for the html report | ||
| includeGroup "org.jetbrains.kotlinx" |
There was a problem hiding this comment.
hm, I would really like to leave one of these for reference on.
There was a problem hiding this comment.
Agree. Maybe we can refactor this into a ## Repositories section and have it listed only once?
There was a problem hiding this comment.
I implemented the @cortinico suggestion. What do you think?
BraisGabin
force-pushed
the
documentation
branch
from
0f73db6
to
d15a1be
Compare
arturbosch
approved these changes
Sep 7, 2020
arturbosch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our gradle documentation is really verbose It repeats the same block of code 5 times so it's difficult to find what you are looking for.
I do think that jcenter is not the best repository and qw should be avoid it when possible. But that's the user choice and our documentation is not the place where we should promote that.