Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last years api deprecations #3035

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added api migration Marker to add a migration step in the changelog labels Aug 29, 2020
@arturbosch arturbosch added this to the 1.13.0 milestone Aug 29, 2020
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #3035 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3035      +/-   ##
============================================
+ Coverage     79.17%   79.30%   +0.13%     
- Complexity     2545     2556      +11     
============================================
  Files           434      432       -2     
  Lines          7731     7718      -13     
  Branches       1468     1467       -1     
============================================
  Hits           6121     6121              
+ Misses          824      811      -13     
  Partials        786      786              
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt 58.33% <ø> (+14.58%) 0.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 93.33% <ø> (ø) 13.00 <0.00> (ø)
...in/io/gitlab/arturbosch/detekt/api/SplitPattern.kt 92.30% <ø> (+3.41%) 19.00 <0.00> (ø)
.../gitlab/arturbosch/detekt/api/internal/BaseRule.kt 100.00% <ø> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33bdaf4...d250fe1. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to remove this.

@arturbosch arturbosch merged commit ad94ebd into master Aug 29, 2020
@arturbosch arturbosch deleted the remove-last-years-deprecations branch August 29, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api migration Marker to add a migration step in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants