Skip to content

Remove obsolete signature workaround for formatting plugin#3038

Merged
arturbosch merged 2 commits intomasterfrom
remove-workaround
Aug 31, 2020
Merged

Remove obsolete signature workaround for formatting plugin#3038
arturbosch merged 2 commits intomasterfrom
remove-workaround

Conversation

@arturbosch
Copy link
Copy Markdown
Member

@arturbosch arturbosch commented Aug 30, 2020

No description provided.

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Aug 30, 2020
@arturbosch arturbosch added this to the 1.13.0 milestone Aug 30, 2020
schalkms
schalkms reviewed Aug 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@schalkms schalkms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some references to getTextSafe.
It's good that some workarounds are finally removed from the codebase.

@arturbosch
Copy link
Copy Markdown
Member Author

arturbosch commented Aug 31, 2020

There are still some reference to getTextSafe.
It's good that some workarounds are finally removed from the codebase.

jap, they were removed in the other PR 👍

@arturbosch arturbosch merged commit c08de81 into master Aug 31, 2020
@arturbosch arturbosch deleted the remove-workaround branch August 31, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schalkms schalkms schalkms left review comments

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arturbosch @cortinico @schalkms