Skip to content

Update spek framework to 2.0.13 - #3070

Merged
schalkms merged 5 commits into
masterfrom
spek-update
Sep 17, 2020
Merged

Update spek framework to 2.0.13#3070
schalkms merged 5 commits into
masterfrom
spek-update

Conversation

@schalkms

@schalkms schalkms commented Sep 13, 2020

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3070 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3070      +/-   ##
============================================
- Coverage     79.27%   79.26%   -0.02%     
  Complexity     2563     2563              
============================================
  Files           432      432              
  Lines          7725     7726       +1     
  Branches       1468     1469       +1     
============================================
  Hits           6124     6124              
  Misses          816      816              
- Partials        785      786       +1
Impacted Files Coverage Δ Complexity Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 75.51% <0.00%> (-1.58%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f8cb4...d6de967. Read the comment docs.

arturbosch
arturbosch approved these changes Sep 13, 2020
View reviewed changes

@arturbosch arturbosch left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice parallel=false by default like junit-jupiter :)
Thanks @raniejade !

@arturbosch arturbosch added this to the 1.13.0 milestone Sep 13, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Sep 13, 2020
@arturbosch

arturbosch commented Sep 13, 2020

Copy link
Copy Markdown
Member

Strange scripting compiler error, can you reproduce it locally?

nit: SPEK2_TIMEOUT is deprecated please use spek2.execution.test.timeout instead.

@arturbosch arturbosch modified the milestones: 1.13.0, 1.14.0 Sep 13, 2020
@schalkms

schalkms commented Sep 14, 2020

Copy link
Copy Markdown
Member Author

@arturbosch I could also see the issued warning locally.
The compileSnippets failure is not reproducible on my local machine. We have had this issue previously though. This happens without having multithreaded test discovery and execution enabled in spek.

@schalkms
Remove duplicate package entries in test snippets
22b4757 
This could be the reason for the exceptions in the JSR223 API (compileAndLint).

org.jetbrains.kotlin.util.KotlinFrontEndException: Front-end Internal error: Failed to analyze declaration Line_51
@schalkms
Remove redundant package entry in test snippets
bee57dc 
Duplicate package entries could be the reason for the exceptions in the JSR223 API (compileAndLint).

org.jetbrains.kotlin.util.KotlinFrontEndException: Front-end Internal error: Failed to analyze declaration Line_51
@schalkms
Use new spek timeout property
b624f30 
This fixes the issued warning by the spek framework.
SPEK2_TIMEOUT is deprecated please use spek2.execution.test.timeout instead
@schalkms
Merge branch 'master' into spek-update
d6de967
@schalkms
schalkms merged commit 793cece into master Sep 17, 2020
@schalkms
schalkms deleted the spek-update branch September 17, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes
@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schalkms @arturbosch @cortinico