-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use File.pathSeparator to split entries in classpath #3084
Use File.pathSeparator to split entries in classpath #3084
Conversation
Like it! This should correctly split entries. |
Codecov Report
@@ Coverage Diff @@
## master #3084 +/- ##
============================================
+ Coverage 79.26% 79.28% +0.02%
- Complexity 2563 2567 +4
============================================
Files 432 434 +2
Lines 7726 7735 +9
Branches 1469 1469
============================================
+ Hits 6124 6133 +9
Misses 816 816
Partials 786 786
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That’s a nice addition! 👍
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/settings/EnvironmentAware.kt
Outdated
Show resolved
Hide resolved
…ettings/EnvironmentAware.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
This is a tiny fix for passing classpath to detekt on windows. I have found pull request where this issue has already been addressed, but I faced another error when passing classpath in a form
C:\Users\petertrr\.m2\repository\dependency1;C:\Users\petertrr\.m2\repository\dependency2
. Classpath string has been split by:
and that produced messageswarning: classpath entry points to a non-existent location: C
. Usage ofFile.pathSeparator
when splitting classpath string solves the issue and I was able to run detekt on windows successfully.