Use File.pathSeparator to split entries in classpath#3084
Merged
schalkms merged 3 commits intodetekt:masterfrom Sep 18, 2020
Merged
Use File.pathSeparator to split entries in classpath#3084schalkms merged 3 commits intodetekt:masterfrom
schalkms merged 3 commits intodetekt:masterfrom
Conversation
|
Like it! This should correctly split entries. |
orchestr7
approved these changes
Sep 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #3084 +/- ##
============================================
+ Coverage 79.26% 79.28% +0.02%
- Complexity 2563 2567 +4
============================================
Files 432 434 +2
Lines 7726 7735 +9
Branches 1469 1469
============================================
+ Hits 6124 6133 +9
Misses 816 816
Partials 786 786
Continue to review full report at Codecov.
|
schalkms
approved these changes
Sep 17, 2020
Member
schalkms
left a comment
schalkms
left a comment
There was a problem hiding this comment.
Thanks! That’s a nice addition! 👍
cortinico
approved these changes
Sep 18, 2020
cortinico
approved these changes
Sep 18, 2020
…ettings/EnvironmentAware.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny fix for passing classpath to detekt on windows. I have found pull request where this issue has already been addressed, but I faced another error when passing classpath in a form
C:\Users\petertrr\.m2\repository\dependency1;C:\Users\petertrr\.m2\repository\dependency2. Classpath string has been split by:and that produced messageswarning: classpath entry points to a non-existent location: C. Usage ofFile.pathSeparatorwhen splitting classpath string solves the issue and I was able to run detekt on windows successfully.