Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlin-reflect problem for idea plugin #3107

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Sep 26, 2020

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Sep 26, 2020
@arturbosch arturbosch added this to the 1.14.1 milestone Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@94b5219). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3107   +/-   ##
=========================================
  Coverage          ?   79.42%           
  Complexity        ?     2598           
=========================================
  Files             ?      437           
  Lines             ?     7821           
  Branches          ?     1486           
=========================================
  Hits              ?     6212           
  Misses            ?      819           
  Partials          ?      790           
Impacted Files Coverage Δ Complexity Δ
...bosch/detekt/api/internal/CommaSeparatedPattern.kt 100.00% <100.00%> (ø) 3.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b5219...ad80e2d. Read the comment docs.

@schalkms
Copy link
Member

Is there any way we can think of to prevent such issues happening again in the future?

@arturbosch
Copy link
Member Author

arturbosch commented Sep 26, 2020

Is there any way we can think of to prevent such issues happening again in the future?

To be honest I don't know and I don't think so.
Seems to be related to callable reference improvements - https://kotlinlang.org/docs/reference/whatsnew14.html#callable-reference-improvements.
Some of these issues can be fixed by migrating away from Spek and Strikt and every other Kotlin library using kotlin-reflect.
The release candidate of Gradle seems to still use 1.3, maybe this will fix everything magically.

Reverting kotlin-reflect does not help - https://stackoverflow.com/questions/63474372/kotlin-delegate-property-causes-a-preview-rendering-error-in-android-studio.

Linking detekt/detekt-compiler-plugin#25

@arturbosch arturbosch merged commit 8c7d678 into master Sep 27, 2020
@arturbosch arturbosch deleted the fix-for-idea-plugin branch September 27, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants