Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Unit returned by method implementations in interfaces #3108

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 27, 2020

Closes #3099

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@94b5219). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3108   +/-   ##
=========================================
  Coverage          ?   79.44%           
  Complexity        ?     2596           
=========================================
  Files             ?      437           
  Lines             ?     7818           
  Branches          ?     1484           
=========================================
  Hits              ?     6211           
  Misses            ?      819           
  Partials          ?      788           
Impacted Files Coverage Δ Complexity Δ
...rbosch/detekt/rules/style/optional/OptionalUnit.kt 80.95% <100.00%> (ø) 24.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b5219...3df4af9. Read the comment docs.

@arturbosch arturbosch added this to the 1.14.1 milestone Sep 27, 2020
@schalkms schalkms merged commit c334513 into detekt:master Sep 27, 2020
@3flex 3flex deleted the 3099-fix branch September 28, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change OptionalUnit to report Unit returned by method implementations in interfaces
4 participants