Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two eager Regex creations in rules which may confuse users if this rules are inactive but evaluated #3154

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.14.2 milestone Oct 18, 2020
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #3154 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3154   +/-   ##
=========================================
  Coverage     79.52%   79.52%           
  Complexity     2592     2592           
=========================================
  Files           437      437           
  Lines          7852     7852           
  Branches       1495     1495           
=========================================
  Hits           6244     6244           
  Misses          817      817           
  Partials        791      791           
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/rules/style/ForbiddenComment.kt 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...b/arturbosch/detekt/rules/style/ForbiddenImport.kt 94.44% <100.00%> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3108bfc...6f03523. Read the comment docs.

@schalkms
Copy link
Member

@arturbosch do you have samples for that?

which may lead to confusing error messages on wrong config properties

@arturbosch arturbosch changed the title Fix two eager Regex creations in rules which may lead to confusing error messages on wrong config properties Fix two eager Regex creations in rules which may confuse users if this rules are inactive but evaluated Oct 19, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Oct 19, 2020
@arturbosch
Copy link
Member Author

@arturbosch do you have samples for that?

which may lead to confusing error messages on wrong config properties

It prevents cases like mentioned in #1064

@arturbosch arturbosch merged commit f155af2 into master Oct 19, 2020
@arturbosch arturbosch deleted the lazy-regexes branch October 19, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants