Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprectad onStart #3172

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Don't use deprectad onStart #3172

merged 1 commit into from
Oct 26, 2020

Conversation

BraisGabin
Copy link
Member

onStart(List<KtFile>) is deprecated and we should use onStart(List<KtFile>, BindingContext)

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #3172 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3172      +/-   ##
============================================
+ Coverage     79.45%   79.50%   +0.04%     
- Complexity     2592     2598       +6     
============================================
  Files           437      438       +1     
  Lines          7871     7914      +43     
  Branches       1501     1509       +8     
============================================
+ Hits           6254     6292      +38     
- Misses          820      821       +1     
- Partials        797      801       +4     
Impacted Files Coverage Δ Complexity Δ
...ules/documentation/LicenceHeaderLoaderExtension.kt 71.87% <ø> (ø) 6.00 <0.00> (ø)
...bosch/detekt/formatting/KtLintLineColCalculator.kt 88.09% <0.00%> (ø) 6.00% <0.00%> (?%)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 96.42% <0.00%> (+0.13%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2705f09...6d00d6f. Read the comment docs.

@schalkms schalkms merged commit b5a423f into detekt:master Oct 26, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 2, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
arturbosch pushed a commit that referenced this pull request Nov 15, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants