Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PreferToOverPairSyntax #3181

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Improve PreferToOverPairSyntax #3181

merged 1 commit into from
Oct 28, 2020

Conversation

t-kameyama
Copy link
Contributor

  • Use visitCallExpression instead of visitSimpleNameExpression
  • Use getResolvedCall(bindingContext) instead of getType(bindingContext)

@t-kameyama
Improve PreferToOverPairSyntax
909d4a7 
- Use `visitCallExpression` instead of `visitSimpleNameExpression`
- Use `getResolvedCall(bindingContext)` instead of `getType(bindingContext)`
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #3181 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3181      +/-   ##
============================================
+ Coverage     79.55%   79.56%   +0.01%     
+ Complexity     2613     2610       -3     
============================================
  Files           439      439              
  Lines          7938     7937       -1     
  Branches       1512     1512              
============================================
  Hits           6315     6315              
  Misses          820      820              
+ Partials        803      802       -1
Impacted Files Coverage Δ Complexity Δ
...ekt/rules/style/optional/PreferToOverPairSyntax.kt 78.57% <66.66%> (+5.23%) 4.00 <1.00> (-3.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7620ce7...909d4a7. Read the comment docs.

schalkms
schalkms approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the code! Looks good!

@schalkms schalkms merged commit 5cef2a1 into detekt:master Oct 28, 2020
@t-kameyama t-kameyama deleted the improve_PreferToOverPairSyntax branch October 28, 2020 11:23
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 2, 2020
arturbosch pushed a commit that referenced this pull request Nov 15, 2020
@t-kameyama @arturbosch
Improve PreferToOverPairSyntax (#3181)
a85db98 
- Use `visitCallExpression` instead of `visitSimpleNameExpression`
- Use `getResolvedCall(bindingContext)` instead of `getType(bindingContext)`
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
@t-kameyama @arturbosch
Improve PreferToOverPairSyntax (#3181)
3c5a24f 
- Use `visitCallExpression` instead of `visitSimpleNameExpression`
- Use `getResolvedCall(bindingContext)` instead of `getType(bindingContext)`
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
@t-kameyama @arturbosch
Improve PreferToOverPairSyntax (#3181)
014d7de 
- Use `visitCallExpression` instead of `visitSimpleNameExpression`
- Use `getResolvedCall(bindingContext)` instead of `getType(bindingContext)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-kameyama @schalkms @arturbosch