Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detektBaseline task filtering .java files #3185

Merged

Conversation

cortinico
Copy link
Member

The util functions Project.registerDetektTask and Project.registerCreateBaselineTask are used to register detekt and detektBaseline tasks on the applied Gradle project.

Due to (I suppose) legacy reason, the registerCreateBaselineTask was still declaring excludes and includes while the registerDetektTask function was updated.

This caused the input source for the detektBaseline to have all the .java files filtered out (resulting in issues like #3130) and generally a different inspection from the one performed by the plain detekt task.

Fixes #3130

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #3185 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3185      +/-   ##
============================================
+ Coverage     79.53%   79.55%   +0.01%     
  Complexity     2631     2631              
============================================
  Files           440      440              
  Lines          7966     7964       -2     
  Branches       1521     1521              
============================================
  Hits           6336     6336              
+ Misses          820      818       -2     
  Partials        810      810              
Impacted Files Coverage Δ Complexity Δ
...o/gitlab/arturbosch/detekt/internal/SharedTasks.kt 57.14% <ø> (+4.96%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0d944...f21076e. Read the comment docs.

@schalkms schalkms merged commit da6259a into detekt:master Oct 29, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
arturbosch pushed a commit that referenced this pull request Nov 15, 2020
* Fix detektBaseline task filtering .java files

* Remove unused import
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
* Fix detektBaseline task filtering .java files

* Remove unused import
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* Fix detektBaseline task filtering .java files

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants