Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken website redirects #3227

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

cortinico
Copy link
Member

It seems like after #3199 (or even before?) we broke redirects.

https://detekt.github.io/detekt/kotlindsl.html should redirect to https://detekt.github.io/detekt/gradle.html. See:

redirect_from:
- /groovydsl.html
- /kotlindsl.html

This is broken right now, I'm fixing it.

@cortinico cortinico changed the title Fix broken websites redirects Fix broken website redirects Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #3227 (559f0cc) into master (cd659ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3227   +/-   ##
=========================================
  Coverage     80.10%   80.10%           
  Complexity     2647     2647           
=========================================
  Files           440      440           
  Lines          8013     8013           
  Branches       1529     1529           
=========================================
  Hits           6419     6419           
  Misses          775      775           
  Partials        819      819           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd659ce...559f0cc. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the site map too after this mege. It should improve a bit the SEO if it's correct. I remember that a fix it once but, probably, it was broken too now.

@schalkms schalkms merged commit 62f2c0d into detekt:master Nov 12, 2020
@cortinico
Copy link
Member Author

@arturbosch Seems like the documentation website is not updated 🤔

The deployment to gh-pages works file:

{"/groovydsl.html":"https://detekt.github.io/detekt/gradle.html","/kotlindsl.html":"https://detekt.github.io/detekt/gradle.html","/type-and-symbol-solving.html":"https://detekt.github.io/detekt/type-resolution.html"}

But GH is failing to publish the website as the /docs folder is missing:
https://github.com/detekt/detekt/runs/1390077842

You should be able to update this in the settings of the repo (deploying pages from root of gh-pages and not from the docs/ folder).

@arturbosch arturbosch added this to the 1.15.0 milestone Nov 12, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 12, 2020
@cortinico
Copy link
Member Author

@arturbosch Seems like the documentation website is not updated 🤔

Now it works correctly 👌

arturbosch pushed a commit that referenced this pull request Dec 21, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants