Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove already activated rules from detekt.yml #3230

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

schalkms
Copy link
Member

Those rules are already activated in the default-detekt-config.yml.

Those rules are already activated in the default-detekt-config.yml.
@schalkms
Copy link
Member Author

based on the idea here
#2838 (comment)

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 12, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3230 (cf52cda) into master (11dbe8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3230   +/-   ##
=========================================
  Coverage     80.09%   80.09%           
  Complexity     2648     2648           
=========================================
  Files           440      440           
  Lines          8013     8013           
  Branches       1528     1528           
=========================================
  Hits           6418     6418           
  Misses          775      775           
  Partials        820      820           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11dbe8d...76d99ea. Read the comment docs.

@arturbosch arturbosch merged commit ccc2931 into master Nov 12, 2020
@arturbosch arturbosch deleted the schalkms-remove-already-activated-rules branch November 12, 2020 23:14
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
Those rules are already activated in the default-detekt-config.yml.
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Those rules are already activated in the default-detekt-config.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants