Update Kotlin to 1.4.21 #3254

arturbosch · 2020-11-28T16:31:40Z

Also updates Gradle and AssertJ and removes the old dokka 1 plugin workaround.

...otlin/io/gitlab/arturbosch/detekt/sample/extensions/processors/QualifiedNameProcessorTest.kt

codecov · 2020-11-28T16:44:57Z

Codecov Report

Merging #3254 (f54e23c) into master (25edc90) will decrease coverage by 0.10%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #3254      +/-   ##
============================================
- Coverage     80.45%   80.34%   -0.11%     
- Complexity     2737     2740       +3     
============================================
  Files           447      448       +1     
  Lines          8287     8279       -8     
  Branches       1573     1581       +8     
============================================
- Hits           6667     6652      -15     
  Misses          772      772              
- Partials        848      855       +7

Impacted Files	Coverage Δ	Complexity Δ
...n/io/gitlab/arturbosch/detekt/core/DetektResult.kt	`90.00% <0.00%> (-10.00%)`	`7.00 <1.00> (ø)`
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt	`27.95% <ø> (ø)`	`19.00 <0.00> (ø)`
...gitlab/arturbosch/detekt/internal/DetektAndroid.kt	`71.87% <ø> (ø)`	`12.00 <0.00> (ø)`
.../io/gitlab/arturbosch/detekt/internal/DetektJvm.kt	`59.25% <ø> (ø)`	`5.00 <0.00> (ø)`
...bosch/detekt/rules/bugs/EqualsWithHashCodeExist.kt	`88.88% <ø> (ø)`	`8.00 <0.00> (ø)`
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt	`87.50% <87.50%> (ø)`	`5.00 <5.00> (?)`
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt	`80.95% <100.00%> (-3.43%)`	`9.00 <1.00> (-2.00)`
.../detekt/metrics/processors/ProjectCLOCProcessor.kt	`100.00% <100.00%> (+5.88%)`	`3.00 <0.00> (ø)`
...n/kotlin/io/gitlab/arturbosch/detekt/rules/Junk.kt	`53.33% <100.00%> (+6.66%)`	`0.00 <0.00> (ø)`
.../io/gitlab/arturbosch/detekt/rules/style/NoTabs.kt	`93.33% <100.00%> (+5.83%)`	`9.00 <0.00> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25edc90...5cc9018. Read the comment docs.

arturbosch · 2020-11-28T16:47:02Z

I'm getting the same stacktrace with Java8 as in CI:

detekt on  update-deps [$] via ☕ v1.8.0
❯ ./detekt-cli/build/run/detekt -i ~/git/repos/detekt
java.lang.RuntimeException: java.util.zip.ZipException: invalid block type
	at org.jetbrains.kotlin.com.intellij.util.ExceptionUtil.rethrow(ExceptionUtil.java:116)
	at org.jetbrains.kotlin.com.intellij.ide.plugins.PluginManagerCore.loadDescriptorFromJar(PluginManagerCore.java:900)
	at org.jetbrains.kotlin.com.intellij.ide.plugins.PluginManagerCore.registerExtensionPointAndExtensions(PluginManagerCore.java:1867)
	at org.jetbrains.kotlin.com.intellij.core.CoreApplicationEnvironment.registerExtensionPointAndExtensions(CoreApplicationEnvironment.java:265)
	at org.jetbrains.kotlin.cli.jvm.compiler.CoreApplicationEnvironmentCompatKt.registerExtensionPointAndExtensionsEx(coreApplicationEnvironmentCompat.kt:17)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment$Companion.registerApplicationExtensionPointsAndExtensionsFrom(KotlinCoreEnvironment.kt:537)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment$Companion.createApplicationEnvironment(KotlinCoreEnvironment.kt:508)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment$Companion.getOrCreateApplicationEnvironmentForProduction(KotlinCoreEnvironment.kt:465)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment$Companion.createForProduction(KotlinCoreEnvironment.kt:419)
	at io.github.detekt.parser.KotlinEnvironmentUtilsKt.createKotlinCoreEnvironment(KotlinEnvironmentUtils.kt:44)
	at io.gitlab.arturbosch.detekt.core.settings.EnvironmentFacade$environment$2.invoke(EnvironmentAware.kt:38)
	at io.gitlab.arturbosch.detekt.core.settings.EnvironmentFacade$environment$2.invoke(EnvironmentAware.kt:22)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at io.gitlab.arturbosch.detekt.core.settings.EnvironmentFacade.getEnvironment(EnvironmentAware.kt)
	at io.gitlab.arturbosch.detekt.core.ProcessingSettings.getEnvironment(ProcessingSettings.kt)
	at io.gitlab.arturbosch.detekt.core.KtTreeCompiler.<init>(KtTreeCompiler.kt:14)
	at io.gitlab.arturbosch.detekt.core.tooling.ParsingStrategyKt$inputPathsToKtFiles$1.invoke(ParsingStrategy.kt:26)
	at io.gitlab.arturbosch.detekt.core.tooling.ParsingStrategyKt$inputPathsToKtFiles$1.invoke(ParsingStrategy.kt)
	at io.gitlab.arturbosch.detekt.core.tooling.Lifecycle$analyze$filesToAnalyze$1.invoke(Lifecycle.kt:34)
	at io.gitlab.arturbosch.detekt.core.tooling.Lifecycle$analyze$filesToAnalyze$1.invoke(Lifecycle.kt:22)
	at io.gitlab.arturbosch.detekt.core.util.PerformanceMonitor.measure(PerformanceMonitor.kt:42)
	at io.gitlab.arturbosch.detekt.core.tooling.Lifecycle$DefaultImpls.measure(Lifecycle.kt:30)
	at io.gitlab.arturbosch.detekt.core.tooling.Lifecycle$DefaultImpls.analyze(Lifecycle.kt:34)
	at io.gitlab.arturbosch.detekt.core.tooling.DefaultLifecycle.analyze(Lifecycle.kt:57)
	at io.gitlab.arturbosch.detekt.core.tooling.AnalysisFacade$runAnalysis$1.invoke(AnalysisFacade.kt:43)
	at io.gitlab.arturbosch.detekt.core.tooling.AnalysisFacade$runAnalysis$1.invoke(AnalysisFacade.kt:21)
	at io.gitlab.arturbosch.detekt.core.tooling.ProcessingSpecSettingsBridgeKt.withSettings(ProcessingSpecSettingsBridge.kt:24)
	at io.gitlab.arturbosch.detekt.core.tooling.AnalysisFacade.runAnalysis$detekt_core(AnalysisFacade.kt:42)
	at io.gitlab.arturbosch.detekt.core.tooling.AnalysisFacade.run(AnalysisFacade.kt:25)
	at io.gitlab.arturbosch.detekt.cli.runners.Runner.call(Runner.kt:33)
	at io.gitlab.arturbosch.detekt.cli.CliRunner.run(CliRunner.kt:33)
	at io.gitlab.arturbosch.detekt.cli.CliRunner.run(CliRunner.kt:15)
	at io.gitlab.arturbosch.detekt.cli.Main.main(Main.kt:19)
Caused by: java.util.zip.ZipException: invalid block type
	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
	at java.io.BufferedInputStream.read(BufferedInputStream.java:265)
	at org.jetbrains.kotlin.com.intellij.openapi.vfs.CharsetToolkit.inputStreamSkippingBOM(CharsetToolkit.java:117)
	at org.jetbrains.kotlin.com.intellij.openapi.util.JDOMUtil.load(JDOMUtil.java:345)
	at org.jetbrains.kotlin.com.intellij.ide.plugins.PluginManagerCore.loadDescriptorFromJar(PluginManagerCore.java:880)
	... 31 more

arturbosch · 2020-11-28T17:27:18Z

Also 1.4.20 introduces reflective access warnings when running detekt ...

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jetbrains.kotlin.com.intellij.util.ReflectionUtil (file:/home/artur/git/repos/detekt/detekt-cli/build/run/detekt) to method java.util.ResourceBundle.setParent(java.util.ResourceBundle)
WARNING: Please consider reporting this to the maintainers of org.jetbrains.kotlin.com.intellij.util.ReflectionUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

schalkms

I saw the same issues locally. What's the plan to move this forward?

arturbosch · 2020-12-16T16:50:51Z

I saw the same issues locally. What's the plan to move this forward?

I haven't really debugged this yet. A quick search was also not successful.
Debugging a detekt run and hold at the crashing point could show some insights.
Maybe we need to configure a new property in the kotlin compiler.

cortinico · 2020-12-16T16:57:56Z

I saw the same issues locally. What's the plan to move this forward?

Should we hold on here till Gradle 6.8 is released?

BraisGabin · 2020-12-19T14:56:46Z

I rebased this PR because it had conflicts and I wanted to check what was happening. I added a commit updating mockk so now the tests in JDK 8 should work.

But I see the same error locally too.

chao2zhang · 2021-01-08T17:16:44Z

Gradle 6.8 is out https://docs.gradle.org/6.8/release-notes.html

cortinico · 2021-01-09T19:33:17Z

Gradle 6.8 is out docs.gradle.org/6.8/release-notes.html

Here you go #3362

cortinico · 2021-01-13T13:04:01Z

Is there anything missing? @schalkms are you taking over this branch?

schalkms · 2021-01-13T22:16:02Z

I handled the merge conflicts. It works for all JDKs except JDK 8, which is interesting. The build task shows the following error.

java -jar ./detekt-cli/build/run/detekt "@./config/detekt/argsfile"
java.lang.RuntimeException: java.util.zip.ZipException: invalid block type

chao2zhang · 2021-01-14T00:03:36Z

I handled the merge conflicts. It works for all JDKs except JDK 8, which is interesting. The build task shows the following error.
java -jar ./detekt-cli/build/run/detekt "@./config/detekt/argsfile"
java.lang.RuntimeException: java.util.zip.ZipException: invalid block type

I am able to reproduce the error locally, which looks like the output executable shadowJarExecutable might not be compatible with this PR.

On the other hand, it looks like running the jar in the traditional way works:
java -jar detekt-cli/build/libs/detekt-cli-1.15.0-all.jar "@./config/detekt/argsfile"

arturbosch · 2021-01-14T03:12:25Z

I handled the merge conflicts. It works for all JDKs except JDK 8, which is interesting. The build task shows the following error.
java -jar ./detekt-cli/build/run/detekt "@./config/detekt/argsfile"
java.lang.RuntimeException: java.util.zip.ZipException: invalid block type
I am able to reproduce the error locally, which looks like the output executable shadowJarExecutable might not be compatible with this PR.

On the other hand, it looks like running the jar in the traditional way works:
java -jar detekt-cli/build/libs/detekt-cli-1.15.0-all.jar "@./config/detekt/argsfile"

I also can confirm this.

Are there other ways to build an executable from a jar?
We could switch to shipping the zip or tar files ...

chao2zhang · 2021-01-14T05:01:53Z

shadowJarExecutable makes it a single executable. If we fallback to detekt-cli/build/libs/detekt-cli-1.15.0-all.jar, we probably need to expose accompanying shell/bat script together.

This probably also explains why we should keep publishing -all.jar as questioned in #3329

chao2zhang · 2021-01-14T05:09:20Z

I was wondering how detekt was added to Homebrew. It looks like @chenrui333 is managing the updates for us ❤️ .

The detekt brew formulae were also using detekt-cli/build/libs/detekt-cli-1.15.0-all.jar

arturbosch · 2021-01-16T20:04:53Z

shadowJarExecutable makes it a single executable. If we fallback to detekt-cli/build/libs/detekt-cli-1.15.0-all.jar, we probably need to expose accompanying shell/bat script together.

This probably also explains why we should keep publishing -all.jar as questioned in #3329

The mentioned zip/tar archives are built with the application plugin, so they include starting scripts.
Oh, we even already upload the zip file - https://github.com/detekt/detekt/releases/download/v1.15.0/detekt-cli-1.15.0.zip
I will go forward and remove the executable so we can finally ship with Kotlin 1.4.21.

…piler (1.4.20+)

arturbosch · 2021-01-16T21:49:45Z

Cool stuff! First time seeing the github integration of detekt:

With this PR merged, we will see some reflection warnings due to https://youtrack.jetbrains.com/issue/KT-43520 :(

buildSrc/src/main/kotlin/MoveJarForIntegrationTestTask.kt

BraisGabin · 2021-01-16T23:30:39Z

I'll see how we can restore the executable. If we remove it we need to update our documentation.

BraisGabin · 2021-01-17T23:23:05Z

It seems that ktlint has the same issue as we have here:

Kotlin added JDK support in 1.4.20 version. Update is blocked, because CLI fails to run with this Kotlin version.

Extracted from: pinterest/ktlint#1063

arturbosch added this to the 1.15.0 milestone Nov 28, 2020

arturbosch commented Nov 28, 2020

View reviewed changes

...otlin/io/gitlab/arturbosch/detekt/sample/extensions/processors/QualifiedNameProcessorTest.kt Show resolved Hide resolved

schalkms reviewed Dec 13, 2020

View reviewed changes

schalkms changed the title ~~Update Kotlin to 1.4.20~~ Update Kotlin to 1.4.21 Dec 13, 2020

schalkms mentioned this pull request Dec 13, 2020

NoSuchMethodError: 'Visibility CallableDescriptor.getVisibility()' on Kotlin 1.4.21 #3282

Closed

chao2zhang mentioned this pull request Dec 14, 2020

Detekt parallel crash #3248

Closed

arturbosch modified the milestones: 1.15.0, 1.16.0 Dec 14, 2020

BraisGabin force-pushed the update-deps branch from fb28f8e to 2fc3270 Compare December 19, 2020 14:55

arturbosch force-pushed the update-deps branch from 2fc3270 to d75b1d3 Compare December 21, 2020 17:58

This comment has been minimized.

Sign in to view

arturbosch force-pushed the update-deps branch from d75b1d3 to b3165bb Compare December 21, 2020 18:29

chao2zhang mentioned this pull request Jan 4, 2021

Introduce coroutines to handle parallelism #3331

Closed

chao2zhang mentioned this pull request Jan 9, 2021

Gradle to 6.8 #3362

Merged

arturbosch added the migration Marker to add a migration step in the changelog label Jan 16, 2021

arturbosch force-pushed the update-deps branch 2 times, most recently from 0a5f88d to abb7931 Compare January 16, 2021 21:18

arturbosch and others added 8 commits January 16, 2021 22:24

Update Kotlin to 1.4.20

30e5a54

Update assertj to 3.18.1

60cf5f1

Fix type V but V!! expected compilation errors with 1.4.20

68c8edc

Remove workaround for old dokka plugin

959fc8f

Update to Kotlin 1.4.21

f344e08

Use jdk8 compatible mockk version

fea53c0

Update mock to version 1.10.4

18f6970

Specify source and target 1.8 java version for KotlinCompile tasks

ecec1c9

arturbosch force-pushed the update-deps branch from abb7931 to 30cf249 Compare January 16, 2021 21:31

Remove shadowJarExecutable as it does not work with newest Kotlin com…

82fb205

…piler (1.4.20+)

arturbosch force-pushed the update-deps branch from 30cf249 to 82fb205 Compare January 16, 2021 21:46

chao2zhang reviewed Jan 16, 2021

View reviewed changes

buildSrc/src/main/kotlin/MoveJarForIntegrationTestTask.kt Outdated Show resolved Hide resolved

chao2zhang approved these changes Jan 16, 2021

View reviewed changes

arturbosch added 2 commits January 17, 2021 00:42

Simplify copying jars for CI by reusing copy task

821be2e

Update cli guide to always use the zip distribution

f537d87

fixup! Simplify copying jars for CI by reusing copy task

5cc9018

arturbosch merged commit a04171a into master Jan 19, 2021

arturbosch deleted the update-deps branch January 19, 2021 20:18

cortinico mentioned this pull request Apr 26, 2021

Precompiled binary not available for 1.16.0 #3690

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Kotlin to 1.4.21 #3254

Update Kotlin to 1.4.21 #3254

arturbosch commented Nov 28, 2020

codecov bot commented Nov 28, 2020 •

edited

Loading

arturbosch commented Nov 28, 2020

arturbosch commented Nov 28, 2020

schalkms left a comment

arturbosch commented Dec 16, 2020

cortinico commented Dec 16, 2020

BraisGabin commented Dec 19, 2020

This comment has been minimized.

chao2zhang commented Jan 8, 2021

cortinico commented Jan 9, 2021

cortinico commented Jan 13, 2021

schalkms commented Jan 13, 2021

chao2zhang commented Jan 14, 2021 •

edited

Loading

arturbosch commented Jan 14, 2021

chao2zhang commented Jan 14, 2021

chao2zhang commented Jan 14, 2021 •

edited

Loading

arturbosch commented Jan 16, 2021

arturbosch commented Jan 16, 2021

BraisGabin commented Jan 16, 2021

BraisGabin commented Jan 17, 2021

Update Kotlin to 1.4.21 #3254

Update Kotlin to 1.4.21 #3254

Conversation

arturbosch commented Nov 28, 2020

codecov bot commented Nov 28, 2020 • edited Loading

Codecov Report

arturbosch commented Nov 28, 2020

arturbosch commented Nov 28, 2020

schalkms left a comment

Choose a reason for hiding this comment

arturbosch commented Dec 16, 2020

cortinico commented Dec 16, 2020

BraisGabin commented Dec 19, 2020

This comment has been minimized.

chao2zhang commented Jan 8, 2021

cortinico commented Jan 9, 2021

cortinico commented Jan 13, 2021

schalkms commented Jan 13, 2021

chao2zhang commented Jan 14, 2021 • edited Loading

arturbosch commented Jan 14, 2021

chao2zhang commented Jan 14, 2021

chao2zhang commented Jan 14, 2021 • edited Loading

arturbosch commented Jan 16, 2021

arturbosch commented Jan 16, 2021

BraisGabin commented Jan 16, 2021

BraisGabin commented Jan 17, 2021

codecov bot commented Nov 28, 2020 •

edited

Loading

chao2zhang commented Jan 14, 2021 •

edited

Loading

chao2zhang commented Jan 14, 2021 •

edited

Loading