Added packagePattern option to config #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauin
approved these changes
Aug 23, 2017
|
This shows that we need to find a way (Wiki, |
Mauin
reviewed
Aug 23, 2017
|
|
||
| class NamingConventionSpec : Spek({ | ||
|
|
||
| given("a kt file with crazy naming schemes") { |
There was a problem hiding this comment.
Should we migrate these test cases over to the other test class to keep the same coverage?
There was a problem hiding this comment.
I'm working on it. I don't know what problem the appveyor build had with my first commit.
There was a problem hiding this comment.
I also noticed the appveyor problem in some of my commits. Kotlin.Unit cannot be loaded ^^
|
It looks like its rdy to merge? |
|
@arturbosch yes |
vanniktech
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also spotted that we have two tests for the
NamingConventionViolationrule. I think one should be deleted because they are basically testing the same thing.EDIT: fixes #327