Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize "active" constant #3292

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Standardize "active" constant #3292

merged 1 commit into from
Dec 17, 2020

Conversation

chao2zhang
Copy link
Member

While working on #3274, I noticed that I cannot find the scope where I need to add severity as a universal config key.
So I created this PR to use Config.ACTIVE_KEY as the root. Please keep in mind that there are still "active" as the string literals not touched in this PR. Those appearances are primarily test code and website generation code.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #3292 (d52c741) into master (2e89bd4) will not change coverage.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3292   +/-   ##
=========================================
  Coverage     80.02%   80.02%           
  Complexity     2667     2667           
=========================================
  Files           443      443           
  Lines          8126     8126           
  Branches       1542     1542           
=========================================
  Hits           6503     6503           
  Misses          796      796           
  Partials        827      827           
Impacted Files Coverage Δ Complexity Δ
...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt 80.00% <0.00%> (ø) 4.00 <0.00> (ø)
...ab/arturbosch/detekt/core/config/FailFastConfig.kt 36.36% <0.00%> (ø) 5.00 <0.00> (ø)
...lin/io/gitlab/arturbosch/detekt/api/ConfigAware.kt 66.66% <100.00%> (ø) 0.00 <0.00> (ø)
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 69.23% <100.00%> (ø) 5.00 <0.00> (ø)
.../arturbosch/detekt/core/reporting/ReportLocator.kt 92.30% <100.00%> (ø) 4.00 <0.00> (ø)
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e89bd4...d52c741. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring. Looks good to me. 🙂

@schalkms schalkms merged commit cc14640 into detekt:master Dec 17, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Dec 18, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Dec 18, 2020
@chao2zhang chao2zhang deleted the active branch December 19, 2020 21:35
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants