Standardize "active" constant - #3292
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=========================================
Coverage 80.02% 80.02%
Complexity 2667 2667
=========================================
Files 443 443
Lines 8126 8126
Branches 1542 1542
=========================================
Hits 6503 6503
Misses 796 796
Partials 827 827
Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 17, 2020
schalkms
left a comment
Member
There was a problem hiding this comment.
Thanks for the refactoring. Looks good to me. 🙂
cortinico
approved these changes
Dec 17, 2020
BraisGabin
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3274, I noticed that I cannot find the scope where I need to add
severityas a universal config key.So I created this PR to use Config.ACTIVE_KEY as the root. Please keep in mind that there are still "active" as the string literals not touched in this PR. Those appearances are primarily test code and website generation code.