Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mix kotlin 1.3 and 1.4 #3309

merged 1 commit into from
Dec 27, 2020


Copy link
Member uses kotlin-reflect. And it uses the version 1.3.72. We should not mix kotlin-reflect 1.3 and kotlin-reflect 1.4.

With this constraint we force kotlin-reflect to update.

We should remove this constraint as soon as we update to a version of that uses kotlin 1.4

This change does little change until we update to gradle 6.8 because we still have the warning but it's a step in the right direction.

Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #3309 (3ff5408) into master (43c7159) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3309   +/-   ##
  Coverage     80.02%   80.02%           
  Complexity     2673     2673           
  Files           443      443           
  Lines          8130     8130           
  Branches       1545     1545           
  Hits           6506     6506           
  Misses          796      796           
  Partials        828      828           
Impacted Files Coverage Δ Complexity Δ
...tlab/arturbosch/detekt/api/internal/PathFilters.kt 88.00% <ø> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c7159...982191f. Read the comment docs.

Copy link

AGP 4.2 is the first version using Kotlin 1.4, which just enters beta02. The expectation for the final release would be April 2021.

@BraisGabin BraisGabin merged commit 43c8a8b into detekt:master Dec 27, 2020
@BraisGabin BraisGabin deleted the kotlin-1-3-and-1-4 branch December 27, 2020 12:13
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Dec 27, 2020
@BraisGabin BraisGabin added this to the 1.16.0 milestone Dec 27, 2020
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request Dec 27, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
housekeeping Marker for housekeeping tasks and refactorings
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants