Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Gradle Plugin to 4.1.1 #3328

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Conversation

chao2zhang
Copy link
Member

This is a prerequisite for #3327.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3328 (7d2e9bb) into master (a9c4e93) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3328   +/-   ##
=========================================
  Coverage     80.33%   80.33%           
  Complexity     2719     2719           
=========================================
  Files           445      445           
  Lines          8165     8165           
  Branches       1552     1552           
=========================================
  Hits           6559     6559           
  Misses          774      774           
  Partials        832      832           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c4e93...7d2e9bb. Read the comment docs.

@BraisGabin
Copy link
Member

This is always a question that I ask myself: should we use the lastest version of AGP? Or should we use the lowest version that we support? And, if so, which versions should we support?

@chao2zhang
Copy link
Member Author

This is always a question that I ask myself: should we use the lastest version of AGP? Or should we use the lowest version that we support? And, if so, which versions should we support?

AGP eventually will be coupled with Gradle, so the policy should be applicable to both.
Eventually, I regard :detekt-gradle-plugin relatively independent from other artifacts, since it is a plugin project.

  • Plugin project does not leak the dependencies to consuming clients.
  • People don't need to rely on detekt-gradle-plugin in order to latest version of detekt.

@BraisGabin BraisGabin added this to the 1.16.0 milestone Dec 27, 2020
@BraisGabin BraisGabin merged commit fb50099 into detekt:master Dec 27, 2020
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request Dec 30, 2020
@chao2zhang chao2zhang deleted the agp4.1.1 branch January 4, 2021 07:41
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants